Autocomplete Wierdness

Problems ? Get help here!
Post Reply
TravisD
Posts: 6
Joined: Sat Jul 16, 2011 5:06 am
Dive Computer: Aeris Atmos 2

Autocomplete Wierdness

Post by TravisD »

First, thanks for supporting my dive computer! I'm grateful to finally have a mac-native dive log program that downloads data :)

Now for the bug report...

Running 2.0.6 (registered).

Not long ago I pulled in a series of dives from a recent trip, and went thru and added my Buddies for each dive. Now whenever I go to set a buddy for each new dive (or any dive for that matter) the Autocomplete in the Buddies field tried everything it can to use the name of the first buddy I ever entered. For example, I had logged buddy "Raymond" earlier. Now when I try and put my usual buddy "Kim" into the Buddy line for new dives, typing "K..." brings up "Raymond". Even when I type further, the R is persistent - so in this case I type "Kim" but Mac-Dive insists on inserting "Rim". I can go back and correct it after typing, but this is obviously not correct behavior.

Now that I have a few buddies logged, typing a character there brings up the list for me to select, but it still wants to keep using that initial "R" for anything new I type.

Let me know if you need more details on this - happy to help out.

-travis
User avatar
nick
Site Admin
Posts: 4376
Joined: Sat Apr 12, 2008 8:33 am
Dive Computer: Shearwater Teric
Contact:

Re: Autocomplete Wierdness

Post by nick »

This is odd - can you email me your MacDive.sqlite file (to support@mac-dive.com) ?

Also, what OS are you running?
TravisD
Posts: 6
Joined: Sat Jul 16, 2011 5:06 am
Dive Computer: Aeris Atmos 2

Re: Autocomplete Wierdness

Post by TravisD »

Sent.

Running OSX 10.6.7
User avatar
nick
Site Admin
Posts: 4376
Joined: Sat Apr 12, 2008 8:33 am
Dive Computer: Shearwater Teric
Contact:

Re: Autocomplete Wierdness

Post by nick »

Choice - got it. Give me a few minutes, I'll take a look now.
User avatar
nick
Site Admin
Posts: 4376
Joined: Sat Apr 12, 2008 8:33 am
Dive Computer: Shearwater Teric
Contact:

Re: Autocomplete Wierdness

Post by nick »

Well, one thing I've just noticed is that it's doing a generic match - so "Raymond" comes up because when you type K, it's matching Raymond's surname. This is possibly what's triggering the issue.

I guess the first question is whether autocomplete should only match from the beginning of a name, not anywhere in the name ?

I think that's more correct than what is happening now.
User avatar
nick
Site Admin
Posts: 4376
Joined: Sat Apr 12, 2008 8:33 am
Dive Computer: Shearwater Teric
Contact:

Re: Autocomplete Wierdness

Post by nick »

Have just emailed you a patched version that incorporates this fix. Let me know if that helps at all?
TravisD
Posts: 6
Joined: Sat Jul 16, 2011 5:06 am
Dive Computer: Aeris Atmos 2

Re: Autocomplete Wierdness

Post by TravisD »

yeah, the "normal" behavior for these things is that, IMO, it should match whatever you've typed up until that point (First available match at least). After you type enough characters to no longer match, then use my input only, but make it clear that it's not using someone autocompleted in case I made a typo.

If matching is being done on the Surname, not the beginning of the string, then perhaps steps need to be taken to make this clear? ( Display Buddies as Last, First? )

Specifically to the case of a dive log, I'm most likely to have the first name of whomever I happen to be diving with. Last name is nice, but I'm more likely to know that I ended up paired with Bob yesterday, not Mr. Smith.

Not a showstopper by any means. And awesome turnaround on the root cause :p

Thanks again.
User avatar
nick
Site Admin
Posts: 4376
Joined: Sat Apr 12, 2008 8:33 am
Dive Computer: Shearwater Teric
Contact:

Re: Autocomplete Wierdness

Post by nick »

No, I think it should only be matching from the start of the name - just an oversight of using "contains" rather than "beginswith" somewhere. I'm surprised I never noticed this before actually.
TravisD
Posts: 6
Joined: Sat Jul 16, 2011 5:06 am
Dive Computer: Aeris Atmos 2

Re: Autocomplete Wierdness

Post by TravisD »

The patched version works as expected. Damn, that's a quick turn-around :P
User avatar
nick
Site Admin
Posts: 4376
Joined: Sat Apr 12, 2008 8:33 am
Dive Computer: Shearwater Teric
Contact:

Re: Autocomplete Wierdness

Post by nick »

Glad to hear it helped!

Good timing.. you caught me with fresh coffee on a Saturday morning :mrgreen:
Post Reply